fix(readcomicOnlineli): Resolves #340 #344
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed some problems when downloading readcomicOnline.li. I debugged a bit and realized there were some problems:
I analyzed the
full_series
function and noticed that thelisting_table
was empty. After some testing, I checkedself.appended_headers
from ReadComicOnlineLi: these additional headers were breaking the connection to the site. I removed some of them and added a way for comic-dl itself to check which platform it is running on (Linux, MacOs, Windows...). This resolved access;After this, I realized that the regex in
single_chapter
that creates the list of comic images had an error. It used double quotes instead of single quotes to filterlstImages.push
:With this list of images, I created a function called
beau
, insideget_image_links
, which is used to decode URLs that have been obfuscated. In the end, it returns a list of image URLs.I ran some tests and verified that the readcomicOnline.li download is working again.
Can you review it?