[Test/#250] Article 목록조회(무한스크롤) Mock API 구현 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
commented
Jul 24, 2024
| @@ -12,10 +12,16 @@ data class ReadArticleUseCaseOut( | |||
| val category: String, | |||
| val createdAt: LocalDateTime, | |||
| val views: Long, | |||
| val includedWorkbooks: List<WorkbookDetail> = emptyList(), | |||
There was a problem hiding this comment.
기존 아티클 단건 조회에서 사용하던 uc out 객체에서 필드 추가했습니다. 아티클 단건 조회 vs 무한 스크롤 API에서 응답 바디가 다를게 이거밖에 없더라구요... 아티클 단건 조회에선 empty로 응답되도록 기본 값을 emptyList()로 설정했습니다.
Comment on lines
+37
to
+52
| val response = ReadArticleResponse( | ||
| id = useCaseOut.id, | ||
| title = useCaseOut.title, | ||
| writer = WriterInfo( | ||
| useCaseOut.writer.id, | ||
| useCaseOut.writer.name, | ||
| useCaseOut.writer.url | ||
| ), | ||
| content = useCaseOut.content, | ||
| problemIds = useCaseOut.problemIds, | ||
| category = useCaseOut.category, | ||
| createdAt = useCaseOut.createdAt, | ||
| views = useCaseOut.views | ||
| ) | ||
|
|
||
| return ApiResponseGenerator.success(response, HttpStatus.OK) |
There was a problem hiding this comment.
기존 아티클 단건 조회 API에서 response 객체를 보시면 uc out dto를 그대로 변환만 하고 있더라구요.. 그냥 변환만 할거면 각 레이어별 DTO를 구분한 의미가 모호해져서 일단 이렇게 컨버팅하는 코드 추가해뒀습니다.
Comment on lines
+55
to
+89
| @GetMapping | ||
| fun readArticles( | ||
| @RequestParam( | ||
| required = false, | ||
| defaultValue = "0" | ||
| ) prevArticleId: Long, | ||
| ): ApiResponse<ApiResponse.SuccessBody<ReadArticlesResponse>> { | ||
| val useCaseOut = readArticlesUseCase.execute(ReadArticlesUseCaseIn(prevArticleId)) | ||
|
|
||
| val articles: List<ReadArticleResponse> = useCaseOut.articles.map { a -> | ||
| ReadArticleResponse( | ||
| id = a.id, | ||
| title = a.title, | ||
| writer = WriterInfo( | ||
| a.writer.id, | ||
| a.writer.name, | ||
| a.writer.url | ||
| ), | ||
| content = a.content, | ||
| problemIds = a.problemIds, | ||
| category = a.category, | ||
| createdAt = a.createdAt, | ||
| views = a.views, | ||
| includedWorkbooks = a.includedWorkbooks.map { w -> | ||
| WorkbookInfo( | ||
| id = w.id, | ||
| title = w.title | ||
| ) | ||
| } | ||
| ) | ||
| }.toList() | ||
|
|
||
| val response = ReadArticlesResponse(articles, articles.size != 10) // TODO refactor 'isLast' | ||
|
|
||
| return ApiResponseGenerator.success(response, HttpStatus.OK) |
There was a problem hiding this comment.
아티클 무한 스크롤링 컨트롤러 코드입니다. 쿼리 파람으로 prevArticleId 가 있고 이전 요청(스크롤)에서 마지막 아티클 ID를 의미합니다. 필수값은 아니며 해당 값이 오지 않을 경우 첫 번째 스크롤로 판단하려고 합니다.
There was a problem hiding this comment.
그리고 지금 당장은 해당 API에 대한 뷰가 1개 밖에 없어서 Facade UC를 둘 필요성이 있을까? 라는 생각이 있어서 일단은 추가 안했어요 (나중에 대응할 뷰가 2개 이상 생기면 필요할 듯)
hun-ca
changed the title
belljun3395
approved these changes
Jul 25, 2024
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved #250
💁♂️ PR 내용
prevArticleId: 이전 스크롤(요청)에서 읽어간 마지막 아티클 ID🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트