[Fix/#281] 아티클 조회수 순 정렬시 옵션 추가(article최신순) #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
commented
Aug 3, 2024
Comment on lines
-59
to
+63
| dslContext | ||
| .select( | ||
| ARTICLE_VIEW_COUNT.ARTICLE_ID, | ||
| rowNumber().over(orderBy(ARTICLE_VIEW_COUNT.VIEW_COUNT.desc())).`as`("offset") | ||
| ) | ||
| .from(ARTICLE_VIEW_COUNT) | ||
| dslContext.select( | ||
| ARTICLE_VIEW_COUNT.ARTICLE_ID, | ||
| rowNumber().over( | ||
| orderBy(ARTICLE_VIEW_COUNT.VIEW_COUNT.desc(), ARTICLE_VIEW_COUNT.ARTICLE_ID.desc()) | ||
| ).`as`("offset") | ||
| ).from(ARTICLE_VIEW_COUNT) | ||
| .where(ARTICLE_VIEW_COUNT.DELETED_AT.isNull) |
There was a problem hiding this comment.
- as-is: VIEW_COUNT 로만 내림 차순 하여 10개 가져옴
- to-be: VIEW_COUNT가 같은 경우 ARTICLE_ID를 내림 차순하는 조건 추가(최신 글 우선)
There was a problem hiding this comment.
CREATE TABLE ARTICLE_VIEW_COUNT
(
article_id BIGINT NOT NULL,
view_count BIGINT NOT NULL,
category_cd TINYINT NOT NULL,
deleted_at TIMESTAMP NULL DEFAULT NULL,
CONSTRAINT article_view_count_pk PRIMARY KEY (article_id)
);위와 같이 article_id에 인덱싱이 되어 있어 인덱스 타고 갑니다
Comment on lines
+86
to
+91
| ).where( | ||
| when (query.category) { | ||
| (null) -> noCondition() | ||
| else -> field("article_view_count_offset_tb.category_cd").eq(query.category.code) | ||
| } | ||
| ).limit(10) |
There was a problem hiding this comment.
카테고리 옵션이 추가로 온 경우에 대해 동적 쿼리 적용했습니다
|
네 확인했슴다.! |
belljun3395
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved #281
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트