[Fix/#283] 아티클 개수가 10의 배수일 경우 마지막 스크롤에서 isLast=false로 응답되는 문제 해결 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
commented
Aug 3, 2024
Comment on lines
-91
to
+90
| ).limit(10) | ||
| ).limit(11) |
There was a problem hiding this comment.
조회수 상위 10개 아티클 ID를 조회할 때 10개가 아닌 11개로 일단 조회
Comment on lines
+45
to
+50
| val isLast = if (articleViewsRecords.size == 11) { | ||
| articleViewsRecords.removeAt(10) | ||
| false | ||
| } else { | ||
| true | ||
| } |
There was a problem hiding this comment.
11개를 조회한 뒤, 그 개수가 11개일 경우에만 해당 스크롤의 isLast 필드를 false로 응답. 그렇지 않으면 true
hun-ca
commented
Aug 3, 2024
Comment on lines
6
to
+7
| enum class CategoryType(val code: Byte, val displayName: String) { | ||
| All(-1, "전체"), // Should not be stored in the DB |
There was a problem hiding this comment.
해당 PR과는 무관하지만 아티클 전체 카테고리 추가되었습니다
belljun3395
approved these changes
Aug 3, 2024
Comment on lines
-100
to
+107
| return ReadArticlesUseCaseOut(articleUseCaseOuts, sortedArticles.size != 10) | ||
| return ReadArticlesUseCaseOut(articleUseCaseOuts, isLast) |
There was a problem hiding this comment.
여기서 10보다 작다로 하면 되는거 아닌가요..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved #283
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트