Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#286] article 전체 카테고리 반영 SQL 수정 #287

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

hun-ca
Copy link
Member

@hun-ca hun-ca commented Aug 3, 2024

🎫 연관 이슈

resolved #286

💁‍♂️ PR 내용

🙏 작업

🙈 PR 참고 사항

📸 스크린샷

image

🤖 테스트 체크리스트

  • 체크 미완료
  • 체크 완료

@hun-ca hun-ca self-assigned this Aug 3, 2024
@hun-ca hun-ca requested a review from belljun3395 as a code owner August 3, 2024 11:43
@github-actions github-actions bot added the fix 기능을 고칠 때 사용됩니다 label Aug 3, 2024
Copy link
Member Author

@hun-ca hun-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드립니다

Comment on lines +87 to 89
when {
(query.category == CategoryType.All) -> noCondition()
else -> field("article_view_count_offset_tb.category_cd").eq(query.category.code)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체 카테고리에 대해 where 조건이 발생되지 않도록 동적쿼리 수정

Copy link
Collaborator

@belljun3395 belljun3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했슴다.!

@hun-ca hun-ca merged commit 373fa96 into main Aug 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 기능을 고칠 때 사용됩니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

아티클 전체 카테고리 변경사항 쿼리 수정
2 participants