[Refactor/#329] 테스트 코드 보강 및 개선 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
force-pushed
the
refactor/#329_belljun3395
branch
from
104f00c to
d069f02
Compare
hun-ca
reviewed
Aug 8, 2024
Comment on lines
-75
to
60
| this.webTestClient.post() | ||
| .uri(uri) | ||
| .accept(MediaType.APPLICATION_JSON) | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| .bodyValue(body) | ||
| .exchange().expectStatus().is2xxSuccessful() | ||
| .expectBody().consumeWith( | ||
| WebTestClientRestDocumentation.document( | ||
| mockMvc.perform( | ||
| post(uri) | ||
| .content(body) | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| ) | ||
| .andExpect(status().isOk) | ||
| .andDo( | ||
| document( | ||
| api.toIdentifier(), |
There was a problem hiding this comment.
저에겐 코파일럿이 있으니까요.!ㅎㅎㅎ
There was a problem hiding this comment.
해주는건 아니고 복붙하기 쉽게 도와준다..?
belljun3395
force-pushed
the
refactor/#329_belljun3395
branch
3 times, most recently
from
64c136e to
8d4cf9b
Compare
belljun3395
commented
Aug 9, 2024
Comment on lines
+47
to
+50
| given("로그인 여부와 상관없이 아티클 조회 요청이 온 상황에서") { | ||
| val articleId = 1L | ||
| val memberId = 1L | ||
| val useCaseIn = ReadArticleUseCaseIn(articleId, memberId) |
There was a problem hiding this comment.
given을 기준으로 useCaseIn을 선언하였습니다.
| val memberId = 1L | ||
| val useCaseIn = ReadArticleUseCaseIn(articleId, memberId) | ||
|
|
||
| `when`("요청한 아티클과 작가가 존재할 경우") { |
There was a problem hiding this comment.
따로 UC에 분기가 없는 경우 존재를 확인합니다.
Comment on lines
+87
to
+100
| then("아티클과 연관된 정보를 조회한다") { | ||
| val useCaseOut = useCase.execute(useCaseIn) | ||
| useCaseOut.id shouldBe articleId | ||
| useCaseOut.writer.id shouldBe writerId | ||
| useCaseOut.writer.name shouldBe writerName | ||
| useCaseOut.writer.url shouldBe mainImageURL | ||
| useCaseOut.writer.imageUrl shouldBe writerProfileImageURL | ||
| useCaseOut.mainImageUrl shouldBe mainImageURL | ||
| useCaseOut.title shouldBe title | ||
| useCaseOut.content shouldBe content | ||
| useCaseOut.problemIds shouldBe problemIds | ||
| useCaseOut.category shouldBe CategoryType.ECONOMY.displayName | ||
| useCaseOut.views shouldBe views | ||
| useCaseOut.workbooks shouldBe emptyList() |
There was a problem hiding this comment.
then에서 uscaseOut도 검증합니다.
Comment on lines
+145
to
+149
| verify(exactly = 1) { articleDao.selectArticleRecord(any()) } | ||
| verify(exactly = 1) { readArticleWriterRecordService.execute(any()) } | ||
| verify(exactly = 0) { browseArticleProblemsService.execute(any()) } | ||
| verify(exactly = 0) { articleViewCountHandler.browseArticleViewCount(any()) } | ||
| verify(exactly = 0) { articleViewHisAsyncHandler.addArticleViewHis(any(), any(), any()) } |
There was a problem hiding this comment.
given 단위로 동일한 동작 수행을 검증합니다.
| @@ -27,69 +29,99 @@ class SaveMemberUseCaseTest : BehaviorSpec({ | |||
| } | |||
|
|
|||
| given("회원가입/로그인 요청이 온 상황에서") { | |||
| val email = "[email protected]" | |||
| val useCaseIn = SaveMemberUseCaseIn(email = email) | |||
|
|
|||
| `when`("요청의 이메일이 가입 이력이 없는 경우") { | |||
There was a problem hiding this comment.
분기가 있는 경우 분기를 기준으로 when을 설정합니다.
belljun3395
force-pushed
the
refactor/#329_belljun3395
branch
from
8d4cf9b to
2937be3
Compare
belljun3395
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #329
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트