[Fix/#338] 구독 학습지 마지막 아티클을 받고 progess를 증가하는 문제해결 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Aug 11, 2024
Comment on lines
-207
to
+209
| val updateTargetMemberRecords = items.filter { it.memberId in successMemberIds } | ||
| val updateTargetMemberRecords = items.filter { it.memberId in successMemberIds }.filterNot { it.memberId in receiveLastDayMemberIds } |
There was a problem hiding this comment.
구독 정보 API에서도 subscription 테이블을 활용해서 사용하는데 구독 완료된 이후 progress를 하나 더 올리면 아티클을 찾는데 -1을 해야하는 추가적인 로직이 들어가야해서 해당 코드를 수정하였습니다.
belljun3395
commented
Aug 11, 2024
| import org.junit.jupiter.api.Test | ||
| import org.mockito.Mockito.* | ||
| import org.springframework.beans.factory.annotation.Autowired | ||
| import kotlin.random.Random | ||
|
|
||
| @Disabled |
There was a problem hiding this comment.
이거는 어느 순간부터 저도 이해하지 못하는 테스트 코드가 되어버려서 다른 이슈로 테스트 코드 추가하겠습니다.!
belljun3395
changed the title
belljun3395
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #338
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
이전에 종료 이후 progess를 하나더 올리는 결과
progess를 하나더 올리지 않는 결과
🤖 테스트 체크리스트