[Refactor/#415] 이메일 전송 목적에 따른 이메일 전송 프로바이더 분리 및 전송 프로바이더 설정할 수 있도록 수정 그리고 전송 이메일 식별자 추가 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Sep 20, 2024
Comment on lines
+4
to
+7
| /** | ||
| * @return 전송한 이메일 식벽을 위한 값 | ||
| */ | ||
| fun sendEmail(from: String, to: String, subject: String, message: String): String |
There was a problem hiding this comment.
전송한 이메일 식별을 위한 반환 값 추가
Comment on lines
+53
to
+59
|
|
||
| /** | ||
| * Default configuration set name is "few-configuration-set" | ||
| */ | ||
| fun getWithConfigurationSetName(): String { | ||
| return "few-configuration-set" | ||
| } |
There was a problem hiding this comment.
aws에서 구성 세트 구분을 위해 추가하였습니다.
Comment on lines
+14
to
+17
| override fun getWithConfigurationSetName(): String { | ||
| return "few-article-configuration-set" | ||
| } | ||
| } |
There was a problem hiding this comment.
아티클 전송을 구분하기 위해 추가하였습니다.
Comment on lines
+12
to
+25
| fun send(args: T, emailSendProvider: EmailSendProvider? = null): String { | ||
| val from = mailProperties.username | ||
| val to = args.to | ||
| val subject = args.subject | ||
| val message = getHtml(args) | ||
| emailSendProvider.sendEmail("FEW Letter <$from>", to, subject, message) | ||
| return emailSendProvider?.sendEmail("FEW Letter <$from>", to, subject, message) | ||
| ?: run { | ||
| defaultEmailSendProvider.sendEmail( | ||
| "FEW Letter <$from>", | ||
| to, | ||
| subject, | ||
| message | ||
| ) | ||
| } |
There was a problem hiding this comment.
메서드에 프로바이더를 넣는다면 넣은 프로바이더로 전송하도록 수정하였습니다.
belljun3395
commented
Sep 24, 2024
|
|
||
| runCatching { | ||
| amazonSimpleEmailService.sendEmail(sendEmailRequest) | ||
| amazonSimpleEmailService.sendEmail(sendEmailRequest).messageId |
There was a problem hiding this comment.
여기의 messageId가 AWS의 emailMessageId가 되어서 메일을 구분할 수 있어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #415
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
SES에서 제공하는 값은 고유하다고 하고
JavaMailSender의 경우에는 고유하다는 것을 보장한다는 코멘트는 없네요..
📸 스크린샷
JavaMailSender messageId 예
🤖 테스트 체크리스트