[UI] #79 세부 UI 수정 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이를 통해 링크를 추가한 경우, 기존 포킷 상세 화면에 표시되는 링크 리스트를 새로고침하는 로직 추가 구현
- 링크 관련 bottomSheet는 해당 UI 디자인 변경으로 인해 아직 미적용한 상태
…출시 링크 제거 bottomSheet가 바로 숨겨지는 문제 수정
# Conflicts: # feature/home/src/main/java/pokitmons/pokit/home/pokit/PokitScreen.kt # feature/home/src/main/res/values/strings.xml # feature/pokitdetail/src/main/java/com/strayalpaca/pokitdetail/PokitDetailScreen.kt
Closed
7 tasks
jiwon2724
reviewed
Nov 20, 2024
core/ui/src/main/java/pokitmons/pokit/core/ui/components/block/toolbar/Toolbar.kt
Show resolved
Hide resolved
Comment on lines
+41
to
+66
| internal fun Modifier.shimmerEffect(): Modifier = composed { | ||
| var size by remember { | ||
| mutableStateOf(IntSize.Zero) | ||
| } | ||
| val transition = rememberInfiniteTransition(label = "infiniteTransition") | ||
| val startOffsetX by transition.animateFloat( | ||
| initialValue = -2 * size.width.toFloat(), | ||
| targetValue = 2 * size.width.toFloat(), | ||
| animationSpec = infiniteRepeatable(animation = tween(1000)), | ||
| label = "infiniteTransitionStartOffsetX" | ||
| ) | ||
|
|
||
| background( | ||
| brush = Brush.linearGradient( | ||
| colors = listOf( | ||
| Gray300, | ||
| Gray500, | ||
| Gray300 | ||
| ), | ||
| start = Offset(startOffsetX, 0f), | ||
| end = Offset(startOffsetX + size.width.toFloat(), size.height.toFloat()) | ||
| ) | ||
| ).onGloballyPositioned { | ||
| size = it.size | ||
| } | ||
| } |
There was a problem hiding this comment.
요거 쉬머 애니메이션 값은 피그마에 정의되어 있었남?
There was a problem hiding this comment.
피그마�에는 단색으로만 표시되어 있어서 일단 임의로 만들었어!
| @@ -18,14 +18,23 @@ class RemindRepositoryImpl @Inject constructor(private val remindDataSource: Rem | |||
| sort: PokitsSort, | |||
| ): PokitResult<List<RemindResult>> { | |||
| return runCatching { | |||
| val response = remindDataSource.getUnreadContents(RemindRequest()) | |||
| val response = remindDataSource.getUnreadContents(RemindRequest(size = size, page = page, sort = sort)) | |||
Comment on lines
230
to
234
| val intent = Intent(Intent.ACTION_SEND_MULTIPLE).apply { | ||
| type = "text/plain" | ||
| putExtra(Intent.EXTRA_TEXT, link.url) | ||
| } | ||
| context.startActivity(Intent.createChooser(intent, "Pokit")) |
There was a problem hiding this comment.
이 부분은 #39 에서 함수로 만들어 놨으니 참고하셔유
jiwon2724
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
Resolves: #79 (merge from #39)
PR 유형
어떤 변경 사항이 있나요?
To Reviewers
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Etc.