[Feature] #86 미분류 링크 분류 화면 구현 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jiwon2724
reviewed
Dec 15, 2024
| import pokitmons.pokit.uncategorized.model.UncategorizedScreenState | ||
| import javax.inject.Inject | ||
|
|
||
| interface UncategorizedViewModel { |
There was a problem hiding this comment.
interface 네이밍에 ViewModel 워딩은 의도된건가욤?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
미분류 포킷 분류 화면을 구현하고
LinkCard의 세부 UI를 수정했습니다. (배경색 및 안읽음 표시 수정)
Resolves: #86
PR 유형
어떤 변경 사항이 있나요?
To Reviewers
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Etc.
기존 화면을 구현할 때는Preview를 사용하기 위해서 [화면이름]ScreenContainer에 ViewModel을 받고
[화면이름]Screen에 여러 메서드들을 인자로 전달하는 방식을 사용했는데, 이렇게 하다보니 너무 인자 개수가 많아지는 것 같아서
이번에는 ViewModel을 인터페이스로 선언하여 사용해봤습니다 (UncategorizedViewModel 참고)
이 방식 괜찮은 것 같으면 앞으로 [화면이름]ScreenContainer로 구현한 부분은 모두 ViewModel 인터페이스를 사용하는 방식으로 리펙토링 진행하려고 합니다!