Update sby_engine_abc.py #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABC will sometimes return negative frame numbers when proving by convergence, e.g. ``` engine_0: Proved output 1 in frame -698905656 (converged). engine_0: Proved output 4 in frame -698905656 (converged). ``` This change fixes these properties being missed and causing the engine status to return UNKNOWN due to `proved_count != len(proved)`.
|
That should be fixed in abc instead of working around it in SBY (or in addition to, the workaround itself is fine and shouldn't cause any additional issues even with it fixed in abc), can you share a project to reproduce this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABC will sometimes return negative frame numbers when proving by convergence, e.g.
This change fixes these properties being missed and causing the engine status to return UNKNOWN due to
proved_count != len(proved).