Helpers v2.1 : download composer globally in /opt/yunohost/composer

[Salamandar]

• download composer globally in /opt/yunohost/composer
• replace --full_replace with --no_clean (disappeared?)
• ynh_in_ci (included in helpers 2.1)
• ynh_setup_source: change the path to the patches
• ynh_setup_source: patch failure is now fatal in CI.

[alexAubin]

download composer globally in /opt/yunohost/composer

Why not but maybe let's use /opt/composer to be consistent with nodejs, ruby, go ?

Also I'm a bit perplexed because I do think some app call composer from some intermediate tool such as roundcube ? (https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/scripts/upgrade#L190) soooo @_@

change the path to the patches

+1 but i need to adapt the autopatch script to handle this properly

[Salamandar]

Why not but maybe let's use /opt/composer to be consistent with nodejs, ruby, go ?

That would be fine with me.

Also I'm a bit perplexed because I do think some app call composer from some intermediate tool such as roundcube ? (https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/scripts/upgrade#L190) soooo @_@

their update.sh contains this:

function find_composer()
{
    if (is_file(INSTALL_PATH . 'composer.phar')) {
        return 'php composer.phar';
    }

    foreach (['composer', 'composer.phar'] as $check_file) {
        $which = trim(system("which $check_file"));
        if (!empty($which)) {
            return $which;
        }
    }

    return null;
}

So I could change this helper to put composer/composer.phar in the PATH.

[alexAubin]

(done in dev but this change is on the .v1 helper, not 2.1)