WIP: app/permissions: Move permissions data out of LDAP #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexAubin
force-pushed
the
move-perm-data-out-of-ldap
branch
3 times, most recently
from
30015ca to
ab7a33b
Compare
alexAubin
force-pushed
the
move-perm-data-out-of-ldap
branch
3 times, most recently
from
6ac59cc to
c5580a0
Compare
alexAubin
force-pushed
the
move-perm-data-out-of-ldap
branch
from
c5580a0 to
9340666
Compare
alexAubin
force-pushed
the
move-perm-data-out-of-ldap
branch
5 times, most recently
from
0175053 to
b31c49d
Compare
alexAubin
force-pushed
the
move-perm-data-out-of-ldap
branch
from
2b651cf to
6896dc8
Compare
alexAubin
commented
Dec 13, 2024
Comment on lines
+30
to
+31
| for app, permissions in permissions_per_app.items(): | ||
| app_setting(app, "_permissions", permissions) |
There was a problem hiding this comment.
Fixme: it doesn't properly migrate the "label" info ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
As foretold a while ago, for various reason, we are going to want to tweak the permission datastructure (because of the auth header policy evolution, or being able to tweak the label, description, logo in the portal) and all the infos are currently in LDAP for not real reason beyond the fact that this is where we store the user<->group<->ACL relationships - but all the other infos (label, url, show_tile etc.) are only meant to be used by ssowat without relying on LDAP.
This is not practical because everytime we want to change the datastructure, we need an LDAP migration, and having everything in settings would also to just simply be able to edit a flat yaml text file which has plenty of benefits.
Solution
Move the url, additional_urls, label, show_tile, and protected infos out of LDAP
PR Status
Yolodraft
How to test
...