Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment method list #2464

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Payment method list #2464

merged 1 commit into from
Oct 29, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Oct 12, 2024

Description

Related issues: ZEUS-2399, ZEUS-2433

When presented with a payment string that has multiple methods, this new ChoosePaymentMethod view replaces the Accounts view to provide a better UX.

Users are presented with all the payment methods, and methods not supported by the backend are faded out:

simulator_screenshot_33BE88D9-D054-44A2-877F-6290DDE59501

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.2 milestone Oct 12, 2024
@kaloudis kaloudis force-pushed the payment-method-list branch from 4532338 to 6ba68fb Compare October 13, 2024 00:02
@kaloudis kaloudis marked this pull request as ready for review October 13, 2024 03:24
@kaloudis kaloudis requested a review from shubhamkmr04 October 13, 2024 03:25
@kaloudis kaloudis force-pushed the payment-method-list branch from 6ba68fb to 0515398 Compare October 28, 2024 15:04
@kaloudis
Copy link
Contributor Author

Addresses to test BOLT-12 offers with and their additional payment methods:

[email protected] - SP
[email protected] - On-chain
[email protected] - SP

Decoder https://satsto.me/

@kaloudis kaloudis force-pushed the payment-method-list branch from 73884fb to 988c381 Compare October 29, 2024 15:06
@kaloudis kaloudis force-pushed the payment-method-list branch from 988c381 to c5df6ae Compare October 29, 2024 15:07
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit f16fb88 into ZeusLN:master Oct 29, 2024
4 checks passed
@kaloudis kaloudis deleted the payment-method-list branch October 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants