Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbound Fee display fixes #2493

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Oct 25, 2024

Description

As is there is a display issue when inbound fees are not defined on a channel.

Before:
Screenshot 2024-10-25 at 3 39 56 PM

After:
Screenshot 2024-10-25 at 3 39 08 PM

This PR also adds remote inbound fees to the fee breakdown.

Before:
Screenshot 2024-10-25 at 3 57 29 PM

After:
Screenshot 2024-10-25 at 3 56 48 PM

Lastly, this PR updates the inbound labels on the SetFeesForm to be consistent with the labels under the fee breakdown.

Before:
simulator_screenshot_DB62D7EA-4A33-493E-B76E-DB26DFC9BBDE

After:
simulator_screenshot_0C914C22-5FA2-436F-A215-9BC1CE8BB4F7

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.2 milestone Oct 25, 2024
@kaloudis kaloudis marked this pull request as ready for review October 25, 2024 20:00
@kaloudis kaloudis requested a review from shubhamkmr04 October 25, 2024 20:04
@kaloudis kaloudis changed the title Channel: Fee Breakdown: hide inbound fees when undefined Inbound Fee display fixes Oct 25, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 1a99689 into ZeusLN:master Oct 28, 2024
4 checks passed
@kaloudis kaloudis deleted the channel-inbound-fee-fixes branch October 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants