Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-2491: force user to set rate on mempool fee suggestion error #2494

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Oct 26, 2024

Description

Relates to issue: ZEUS-2491

  • Users must now manually set a fee rate when mempool fee suggestion fails, when opening a channel, closing a channel, or making an on-onchain transaction
  • Opening a channel, closing a channel, and making an on-onchain transaction is blocked when the fee rate is set to 0 sats/vbyte
  • On the Open Channel view the fee input form is now moved out and above the Advanced settings section
  • Fixes display of the icon on the Open Channel button on the Open Channel view
  • OnchainFeeInput: when suggestions are disabled, force users to manually set the fee rate before proceeding

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added the Fees label Oct 26, 2024
@kaloudis kaloudis added this to the v0.9.2 milestone Oct 26, 2024
@kaloudis kaloudis linked an issue Oct 26, 2024 that may be closed by this pull request
@myxmaster
Copy link
Contributor

Very nice, just one thing needs to be fixed:
You can still close a channel without setting a custom fee rate (button 'CONFIRM CHANNEL CLOSE' ist not disabled).

@kaloudis
Copy link
Contributor Author

Very nice, just one thing needs to be fixed: You can still close a channel without setting a custom fee rate (button 'CONFIRM CHANNEL CLOSE' ist not disabled).

This is intentional as the fee rate on the CloseChannel call is optional https://lightning.engineering/api-docs/api/lnd/lightning/close-channel/index.html

@myxmaster
Copy link
Contributor

Ah of course, the nodes negotiate the fee, I forgot :)

Then it's good to go imo.

@kaloudis kaloudis merged commit 0f8cbe2 into ZeusLN:master Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if mempool fee suggestion is not available: do not use 1 sat/vB
2 participants