Contacts: Refactor, bugfixes, improved logic/behaviour #2667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First I just wanted to fix #2423. But while looking into the implementation, there was a lot more to do...
Refactor:
ContactInputField
component for reusable field inputs (easier to maintain and now 1297 lines vs. before 1525)Bugfixes:
marginHorizontal: 24
forinputContainer
)marginTop
for dividers now (normal vs. additional fields)clearPrefillContact()
is now called -> before, old data was visible, when you deleted a contact and then created a new one[mobx.array] Attempt to read an array index (0) that is out of bounds (0). Please check length first. Out of bound indices will not be tracked by MobX
Improved logic/behvaiour:
-> "Delete" icon always visible for additional fields now of course
saveContact()
with new helper functioncompactContactArrays()
(removing empty fields/gaps)This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: