Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modules properly and allow composability #44

Closed
wants to merge 7 commits into from
Closed

Use modules properly and allow composability #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f6b373
Replace jschardet namespace by regular modules
jdesboeufs Nov 17, 2017
476b9c9
Split mbcssm into independant modules
jdesboeufs Nov 19, 2017
8b1f8da
Restore ability to enable logger
jdesboeufs Nov 20, 2017
4ef274b
Restore ability to set minimum threshold
jdesboeufs Nov 20, 2017
fbd8a49
Fix bundling
jdesboeufs Nov 20, 2017
2b187c5
Update dist
jdesboeufs Nov 20, 2017
f54183a
Fix entrypoint
jdesboeufs Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ Options
```javascript
// See all information related to the confidence levels of each encoding.
// This is useful to see why you're not getting the expected encoding.
jschardet.Constants._debug = true;
jschardet.setLogger();
Copy link
Owner

@aadsm aadsm Nov 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is not clear of its purpose. I had to read the setLogger code to figure out what it was doing.
My first reaction was to think that this wouldn’t do any logging because you were setting the logger to nothing.
Let’s add two functions: {enable, disable}Logging().


// Default minimum accepted confidence level is 0.20 but sometimes this is not
// enough, specially when dealing with files mostly with numbers.
// To change this to 0 to always get something or any other value that can
// work for you.
jschardet.Constants.MINIMUM_THRESHOLD = 0;
jschardet.detect(str, { minimumThreshold: 0 });
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

```

Supported Charsets
Expand Down
Loading