Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pyusd Merit campaign #2265

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

NandyBa
Copy link
Contributor

@NandyBa NandyBa commented Nov 26, 2024

General Changes

Developer Notes

This campaign will be live Wednesday 27th
ACI Merit endpoint is already live


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

height bot commented Nov 26, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:00pm

Copy link

vercel bot commented Nov 26, 2024

@NandyBa is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Nov 26, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/12033613418'

Copy link

customForumLink:
'https://governance.aave.com/t/arfc-pyusd-reserve-configuration-update-incentive-campaign/19573',
customMessage:
'You must supply PYUSD in order to receive merit rewards. Note that there is a undesire debt token list. If you borrow any of these tokens you will get your rewards reduced. Please check the forum post for more information.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update customMessage to be

Borrowing of some assets may impact the amount of rewards you are eligible for. Please check the forum post for the full eligibility criteria.

Copy link

github-actions bot commented Nov 26, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/12035694473'

Copy link

@foodaka foodaka merged commit e14f31b into aave:main Nov 27, 2024
13 of 14 checks passed
foodaka added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants