Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask Merit campaign when aprs are not found #2270

Merged

Conversation

NandyBa
Copy link
Contributor

@NandyBa NandyBa commented Nov 28, 2024

General Changes

Merit campaigns can be temporarily paused. This pull request introduces functionality to quickly disable the incentive box during such pauses.

It's important to note that paused campaigns often indicate that clients are taking some time to reflect before deciding to renew the incentives, rather than always signaling the end of the campaign.

  • mask incentive box when the corresponding Merit campaign is temporary paused, preventing the following:
Capture d’écran 2024-11-28 à 11 51 38

Developer Notes

RAS


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

appear when some campaigns are temporary disabled
Copy link

height bot commented Nov 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 11:49am

Copy link

vercel bot commented Nov 28, 2024

@NandyBa is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Dec 9, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/12240847564'

Copy link

github-actions bot commented Dec 9, 2024

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 542.71 KB (🟢 -1.69 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 47.44 KB (🟢 -156 B) 590.15 KB
/bridge 36.01 KB (🟢 -25 B) 578.71 KB
/markets 26.97 KB (🟢 -156 B) 569.68 KB
/staking 22.93 KB (🟢 -156 B) 565.64 KB
/v3-migration 30.26 KB (🟢 -156 B) 572.97 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@grothem grothem merged commit 3364b1a into aave:main Dec 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants