Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'sees' typo in consider_river switch #660

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Jan 12, 2024

Replace "rivers or sees" with "rivers, lakes, etc.", based on wording proposed by @gnbl in nrenner/brouter-web#747.

@quaelnix
Copy link
Collaborator

@afischerdev, the profiles on the server apparently have not been updated for months. Could we sync them?

@afischerdev
Copy link
Collaborator

@quaelnix
I'll try that, have never done it before and don't know if my rights will work for that.

But we should do a minimal change: set the default new in

trekking.brf
assign   ignore_cycleroutes  = true

as discussed e.g. here.
That seems to be the main concern. All the other pending things could be discussed later on.

@afischerdev afischerdev merged commit 0a3aa3a into abrensch:master Jan 15, 2024
1 check passed
@waldyrious waldyrious deleted the typo-sees branch January 15, 2024 18:03
@quaelnix
Copy link
Collaborator

quaelnix commented Jan 16, 2024

But we should do a minimal change: set the default new in

Why should we do that? There is even a dedicated trekking profile for exactly that case on the brouter.de server: https://brouter.de/brouter-web/#map=7/51.011/10.015/standard,route-quality&profile=trekking-ignore-cr

I might have overreacted a bit in that pull request, but disabling ignore_cycleroutes by default makes zero sense.

@afischerdev
Copy link
Collaborator

@quaelnix
You are right. I always forget that feature.
I only use the plain versions and so I always get a little irritated when I encounter the ignore_routes parameter..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants