Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PMD to 7.0.0 #689

Merged
merged 14 commits into from
Apr 17, 2024
Merged

Update PMD to 7.0.0 #689

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e2752c7
Remove AndroidManifests for pure java libraries
zod Apr 3, 2024
1573aa5
Upgrade to AGP 8.0 and Gradle 8.4
zod Apr 3, 2024
2f7ce42
Upgrade to PMD 7.0.0 and disable violated rules
zod Apr 3, 2024
dd89634
Fix newly detected violations from PMD 7
zod Apr 3, 2024
c73a8ce
Enable PMD rule UnnecessaryBoxing and fix violations
zod Apr 3, 2024
6c22d7d
Update workflows to java 17
zod Apr 3, 2024
b8929ab
Global build ignore
zod Apr 5, 2024
5d4065d
Use conventions instead of cross-project configuration
zod Apr 5, 2024
258a0c1
Remove leftover maven file
zod Apr 5, 2024
8e3c9a9
Target Java 11
zod Apr 5, 2024
13781fb
fixup! Upgrade to AGP 8.0 and Gradle 8.4
zod Apr 5, 2024
d969ac1
Downgrade AGP version for IntelliJ IDEA compatibility
zod Apr 5, 2024
83f001e
Merge branch 'master' into pmd-7
zod Apr 15, 2024
47f5812
Add dependency on brouter-routing-app for distZip
zod Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gradle-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
settings-path: ${{ github.workspace }} # location for the settings.xml file
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
environment: BRouter
steps:
- uses: actions/checkout@v4
- name: Set up JDK 11
- name: Set up JDK 17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark only, the BRouter server still uses JDK 11.
Therefore, the output lib cannot be used directly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to compile for older Java releases we should target a specific java version. It seems reasonable to target Java 11 but use JDK 17 to build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For maximum compatibility with old Android versions (that do not contain newer Java API),
in the open source libraries I maintain, we may use Java 17 to compile,
but have sourceCompatibility and targetCompatibility with JavaVersion.VERSION_1_8.

For example:
https://github.com/mapsforge/mapsforge/blob/master/build.gradle#L32-L33
https://github.com/mapsforge/vtm/blob/master/build.gradle#L34-L35

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, I could try sourceCompatibility and targetCompatibility next week with the test server.

uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: gradle
- name: Create local.properties
Expand Down