Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes for french language #698

Closed
wants to merge 2 commits into from
Closed

Conversation

alkino
Copy link

@alkino alkino commented May 13, 2024

The main one is Gratuit > Libre
Gratuit means free as in free beer.
Libre means free as in available place.

The main one is `Gratuit` > `Libre`
Gratuit means free as in free beer.
Libre means free as in available place.
@devemux86
Copy link
Contributor

devemux86 commented May 13, 2024

@alkino

Thanks, may I ask about why inserting a space before the punctuation marks?

@alkino
Copy link
Author

alkino commented May 13, 2024

Because in french this is not correct to not insert one.

https://en.wikipedia.org/wiki/History_of_sentence_spacing#French_and_English_spacing

French spacing inserted spaces around most punctuation marks, but single-spaced after sentences, colons, and semicolons.

This is really a typographic mistake to not add one.

@devemux86
Copy link
Contributor

@alkino then is it needed a non-breaking space to avoid line break with punctuation mark alone in next line?

 

@alkino
Copy link
Author

alkino commented May 13, 2024

Yes, it would be better.

@afischerdev
Copy link
Collaborator

May be a   could do the job.

@afischerdev
Copy link
Collaborator

@alkino
Your PR has not passed the build process.
Please see here
Do you like to complete it?

@alkino alkino closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants