Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New voicehints for motorway exit #742

Merged
merged 7 commits into from
Dec 14, 2024

Conversation

afischerdev
Copy link
Collaborator

This is the PR for #734

The problem with this new voicehints is, not all clients are ready for using.
First rule: the export contains what the clients can read. Means

  • Locus already has this tags of Exit Left / Right
  • all other become the old values - we can change later

For testing select you favorite turnInstructionMode.
Please use for a direct test export the button between close and export.
When using JSON export you could select turnInstructionMode = 2 to get the new index.

For OsmAnd exists a special turnInstructionMode = 8. This is not reachable via the profile dialog, you have to set this inside the profile editor. It can be used to prepare OsmAnd to the new voicehints before BRouter delivers the new tags on turnInstructionMode = 3.

A Test is possible on the test server: route

@devemux86 @vshcherb @vodie @menion
Please let us know when you change your rules in your apps, so we can go on to normalize the voicehint situation.

@devemux86
Copy link
Contributor

@afischerdev

Please use for a direct test export the button between close and export.

Can you explain what is the difference between the middle "cloud" button and the export button?

@afischerdev
Copy link
Collaborator Author

@devemux86
The export uses the web client internal export, the cloud button exports without reworking.

@devemux86
Copy link
Contributor

@afischerdev
I have seen that GPX navigation tracks can only be exported with the middle "cloud" button.
(and turnInstructionMode 2)

@@ -26,6 +26,8 @@ public class VoiceHint {
static final int RNLB = 14; // Roundabout left
static final int TU = 15; // 180 degree u-turn
static final int BL = 16; // Beeline routing
static final int EL = 17; // Beeline routing
static final int ER = 18; // Beeline routing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afischerdev The comments here should mention the exit instructions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks better

@devemux86
Copy link
Contributor

@afischerdev Thanks for this implementation. 👍

Does the test server need a restart?
Routing returns "502 Bad Gateway".

@afischerdev
Copy link
Collaborator Author

Just restarted

@afischerdev
Copy link
Collaborator Author

Just add a logic that also find motorway exits when there are no more entries.
Therefore I added an new END voicehint type and throw it away after calculation.
This is also already available on testserver.

@devemux86
Copy link
Contributor

@afischerdev

Should the clients do something with this?
Or it is handled internally and is mapped to the EL / ER instructions?

@afischerdev
Copy link
Collaborator Author

@devemux86
It was only an internal update to get more exit nodes.
As before the client only has to handle the new voicehints.

@afischerdev afischerdev added this to the 1.7.8 milestone Nov 21, 2024
@devemux86
Copy link
Contributor

@afischerdev

As before the client only has to handle the new voicehints.

You mean the 2 new EL + ER instructions.
(not the END)

@afischerdev
Copy link
Collaborator Author

@devemux86
Yes, this is only for temporary and internal use (discussable).

@menion
Copy link

menion commented Nov 21, 2024

Thanks @afischerdev , VoiceHint commands 17 EL and 18 ER support will be added to the Locus Map platform.

@afischerdev afischerdev merged commit 625ff0c into abrensch:master Dec 14, 2024
2 checks passed
@afischerdev afischerdev deleted the new-voicehints branch December 14, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants