Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Vitals - Extract update logic to separate functions #10566

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Medical Vitals - Extract update logic to separate functions #10566

wants to merge 12 commits into from

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Makes more sense IMO. Intent is for events to be used as API (IV medication/incompatible blood transfusions, for example).

Event deferral is just to keep any code from the events out of the vitals counter, but they can just be raised straight with no problems.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim marked this pull request as draft December 17, 2024 22:05
@LinkIsGrim LinkIsGrim added the kind/cleanup Release Notes: **CHANGED:** label Dec 17, 2024
@LinkIsGrim
Copy link
Contributor Author

On another note:

  • VAR_HEMORRHAGE doesn't have any usage (and I don't think it's API?)
  • VAR_IN_PAIN could be replaced with a comparison with GET_PAIN_PERCEIVED > 0 (which is what is done in the state update, point is, we could drop the network update by doing a cheap comparison)

Drop 'em?

@LinkIsGrim LinkIsGrim changed the title Medical Vitals - Extract iv/medication consumption & state update Medical Vitals - Extract update logic to separate functions Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@rautamiekka rautamiekka rautamiekka requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinkIsGrim @rautamiekka @PabstMirror