Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drmorr/remove exclude daemonsets #159

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Nov 17, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Remove the exclude_daemonsets flag because it's not actually doing anything

Testing done

  • make test

@drmorr0 drmorr0 force-pushed the drmorr/remove-exclude-daemonsets branch from 18d1228 to a824caa Compare November 17, 2024 06:24
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.16%. Comparing base (c2f14c8) to head (a824caa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sk-cli/src/export.rs 0.00% 1 Missing ⚠️
sk-cli/src/snapshot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          53       53           
  Lines        2769     2769           
=======================================
  Hits         2026     2026           
  Misses        743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 merged commit 144c133 into master Nov 17, 2024
7 of 8 checks passed
@drmorr0 drmorr0 deleted the drmorr/remove-exclude-daemonsets branch November 17, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant