Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gha-runner-scale-set-controller.chart instead of .Chart.Version #3729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use gha-runner-scale-set-controller.chart instead of .Chart.Version #3729

wants to merge 2 commits into from
+1 −1

Conversation

Mikey032
Copy link

@Mikey032 Mikey032 commented Sep 4, 2024 •
edited
Loading

Solves #3728

@Mikey032
Copy link
Author

@mumoshu @rentziass @toast-gear can you have a look?

@madAndroid
Copy link

I've just hit this as well, would love to have it merged 🙏

madAndroid added a commit to madAndroid/actions-runner-controller that referenced this pull request Sep 20, 2024
@madAndroid
Fixes from actions#3729
5b6d1be
@evilhamsterman
Copy link

This also solves #3772. This is a pretty big issue for some people with a pretty easy one line fix can some merge it soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mikey032 @madAndroid @evilhamsterman