Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failure build from old repository #11194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whywaita
Copy link
Contributor

@whywaita whywaita commented Dec 15, 2024

Description

Bug fixing.

As shown below, the current packages.erlang-solutions.com always responds with a 304 status.

curl -v https://packages.erlang-solutions.com/ubuntu/erlang_solutions.asc
* About to connect() to packages.erlang-solutions.com port 443 (#0)
*   Trying 13.33.21.118... connected
* Connected to packages.erlang-solutions.com (13.33.21.118) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate:
*       subject: CN=*.erlang-solutions.com
*       start date:  7月 07 11:44:33 2024 GMT
*       expire date:  8月 08 11:44:33 2025 GMT
*       common name: *.erlang-solutions.com
*       issuer: CN=Go Daddy Secure Certificate Authority - G2,OU=http://certs.godaddy.com/repository/,O="GoDaddy.com, Inc.",L=Scottsdale,ST=Arizona,C=US
> GET /ubuntu/erlang_solutions.asc HTTP/1.1
> User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.27.1 zlib/1.2.3 libidn/1.18 libssh2/1.4.2
> Host: packages.erlang-solutions.com
> Accept: */*
>
< HTTP/1.1 304 Not Modified
< Connection: keep-alive
< Date: Sun, 15 Dec 2024 05:40:14 GMT
< ETag: "c3d-58987958a1c80"
< Cache-Control: max-age=3600, public
< X-Cache: Miss from cloudfront
< Via: 1.1 10084ccafdc318e0abba7148b0b1b088.cloudfront.net (CloudFront)
< X-Amz-Cf-Pop: LAX53-P2
< X-Amz-Cf-Id: ejWQLomoDyLuVBYdlywLdEE5gWJ_rU8JoldEZyz4LFxyfuejsA1iGw==
<
* Connection #0 to host packages.erlang-solutions.com left intact
* Closing connection #0

Referring to the official site https://www.erlang-solutions.com/downloads/, it is currently recommended to use binaries2.erlang-solutions.com.

This PR updates the repository configuration to use the new repository.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will see if this works 👍

@whywaita whywaita force-pushed the switch-new-gpg-erlang branch from a0bcb83 to eccb0f4 Compare December 17, 2024 08:06
@whywaita
Copy link
Contributor Author

@Kichura @dav3yblaz3 Sorry for the mistake in the code. I’ve made the necessary corrections.

The list of repository names can be found here:
https://binaries2.erlang-solutions.com/#ubuntu/dists/

I’ve updated the code to use esl-erlang-25.
Please review it again.

@whywaita
Copy link
Contributor Author

I checked it works in https://github.com/whywaita/actions-runner-images-lxd/actions/runs/12367569657/job/34516087683#step:15:19321

CI is a failure, but installing erlang is a success from http://binaries2.erlang-solutions.com/ubuntu focal-esl-erlang-25

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this will fixA

@whywaita
Copy link
Contributor Author

Is there anything else I should do?

@dav3yblaz3
Copy link

dav3yblaz3 commented Dec 18, 2024 via email

@dav3yblaz3
Copy link

dav3yblaz3 commented Dec 18, 2024 via email

@dav3yblaz3
Copy link

dav3yblaz3 commented Dec 18, 2024 via email

@whywaita
Copy link
Contributor Author

I already fix it. Please review it.
eccb0f4

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you greatest team lets add this to test

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give this a try team

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us try this

@@ -11,8 +11,8 @@ source_list=/etc/apt/sources.list.d/eslerlang.list
source_key=/usr/share/keyrings/eslerlang.gpg

# Install Erlang
wget -q -O - https://packages.erlang-solutions.com/ubuntu/erlang_solutions.asc | gpg --dearmor > $source_key
echo "deb [signed-by=$source_key] https://packages.erlang-solutions.com/ubuntu $(lsb_release -cs) contrib" > $source_list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please let us get this added and see if fix

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good for test thank you

Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us try this thanks team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants