Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial cache keys for poetry environments #656

Closed
wants to merge 1 commit into from

Conversation

krishanbhasin-gc
Copy link

@krishanbhasin-gc krishanbhasin-gc commented Apr 21, 2023

Description:
Allows the action to use partial-key matching as a fallback when the cache misses.

This will save much compute time for dependency upgrade scenarios.

Related issue:
#627

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dusan-trickovic dusan-trickovic linked an issue Jul 13, 2023 that may be closed by this pull request
@dusan-trickovic
Copy link

Hello @krishanbhasin-gc ! I apologize for the late response. Unfortunately, our team has decided not to proceed with the original issue #627 and, therefore, this PR. The reason for this decision (as well as for closing the issue in the first place) mostly stems from the fact that this could cause the snowballing effect with dependencies - as the package manager can't handle the removal of stale ones. In other words, it would install new package versions, but would also keep the old ones.

With this in place, the cache size would continue to grow and grow until it, essentially, lost its original purpose and efficiency. So, at least right now, we don't think there's much of anything we can do regarding this.

In any case, however, we appreciate your input and thank you very much for your time and contribution!

@dusan-trickovic dusan-trickovic added the won't fix This will not be worked on label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow partial cache keys
2 participants