Throwing an error in getManifestFromRepo when the github API rate limiting response is a JSON object.

[Lavaerius]

Description:

Updates fail condition for getManifestFromRepo function to include instances when github responds with JSON body for API rate limiting, that is incorrectly handled.
Related issue:

#903

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[konradpabjan]

Dist/index.js is not where these changes should be directly made.

This index.js is a form of webpack and gets auto-generated from the source files in the src directory.

setup-python/package.json

Line 13 in 70dcb22

"release": "ncc build -o dist/setup src/setup-python.ts && ncc build -o dist/cache-save src/cache-save.ts && git add -f dist/",

Fundamentially you're trying to update the getManifestFromRepo function. That can be found here:

setup-python/src/install-python.ts

Lines 47 to 57 in 70dcb22

	export function getManifestFromRepo(): Promise<tc.IToolRelease[]> {
	core.debug(
	`Getting manifest from ${MANIFEST_REPO_OWNER}/${MANIFEST_REPO_NAME}@${MANIFEST_REPO_BRANCH}`
	);
	return tc.getManifestFromRepo(
	MANIFEST_REPO_OWNER,
	MANIFEST_REPO_NAME,
	AUTH,
	MANIFEST_REPO_BRANCH
	);
	}

That uses a function from the our tool-cache NPM package in the actions/toolkit repository. This is the actual place where the change would need to be made: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/tool-cache/src/tool-cache.ts#L589-L632

So upstream the change would need to be made to tool-cache, a new version would then need to be published and then pulled into this repository/action. https://www.npmjs.com/package/@actions/tool-cache

I recommend submitting a PR to https://github.com/actions/toolkit

[Lavaerius]

Appreciate the feedback on this issue. I'll investigate your recommendation.

[Mrvp215]

tun

[mahabaleshwars]

Hello @Lavaerius,

Are you planning to make modifications to this PR as per @konradpabjan's suggestion?
Please update your input so that we can move this forward and resolve the issue.

Thank you!

[Lavaerius]

Yes, I'll look into that.

[Lavaerius]

I've submitted:
actions/toolkit#1832

[Mrvp215]

tun