-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Rotten Issues #1140
Open
mviswanathsai
wants to merge
7
commits into
actions:main
Choose a base branch
from
mviswanathsai:rotten-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: Rotten Issues #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add processRottenIssue Add Options to support rotten issues Update main.ts to process rotten related inputs Update the Option enum to include rotten related variables Update issue.ts to include function to get the rotten label Add helper functions for rotten related options
8 tasks
IMO the naming here is kind of counterintuitive; I'd expect stale to come first before rotten... |
Yes, it is stale -> rotten -> closed. |
ah, got it, sorry, I just misunderstood at first... never mind... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to add functionality that lets the user keep an issue in an intermediate state between stale and closed: rotten. This enables the user to do Kubernetes-like (a very mild like) issue life-cycle management. This is done in Kubernetes using the traige-robot.
As per the changes in this PR, after an issue is created:
days-before-stale
.Stale
state.Stale
till a time period specified bydays-before-rotten
.Rotten
state.Rotten
till a time period specified bydays-before-close
.Stale
andRotten
.days-before-rotten: -1
i.e., does not rotten any issues and so does not disturb the flow of users who have already setup the action. However, provides the user with the option to use the new state if need be. So the default flow isStale
--> closed.Note: "This bot" refers to the triage-robot.
Related issue:
Check list: