Update commenter type #1177
Update commenter type #1177
Conversation
|
@MaksimZhukov @jmeridth , sorry for the direct mentions but it looks like you both were some of the last approver's 😰 |
|
@HarithaVattikuti I noticed that you had reviewed something previously and I didn't know if there were other channels / means to request a review |
|
@gowridurgad I noticed you reviewed the last dependabot pr and was wondering if you could take a peak at this? |
__tests__/main.spec.ts
Outdated
| @@ -1209,7 +1209,7 @@ test('stale issues should not be closed if days is set to -1', async () => { | |||
| expect(processor.removedLabelIssues).toHaveLength(0); | |||
| }); | |||
|
|
|||
| test('stale label should be removed if a comment was added to a stale issue', async () => { | |||
| test('stale label should be removed if a User comment was added to a stale issue', async () => { | |||
There was a problem hiding this comment.
| test('stale label should be removed if a User comment was added to a stale issue', async () => { | |
| test('stale label should be removed if a user comment was added to a stale issue', async () => { |
__tests__/main.spec.ts
Outdated
| @@ -1247,6 +1247,44 @@ test('stale label should be removed if a comment was added to a stale issue', as | |||
| expect(processor.removedLabelIssues).toHaveLength(1); | |||
| }); | |||
|
|
|||
| test('stale label should not be removed if a Bot comment was added to a stale issue', async () => { | |||
There was a problem hiding this comment.
| test('stale label should not be removed if a Bot comment was added to a stale issue', async () => { | |
| test('stale label should not be removed if a bot comment was added to a stale issue', async () => { |
| @@ -810,7 +810,7 @@ export class IssuesProcessor { | |||
|
|
|||
| const filteredComments = comments.filter( | |||
| comment => | |||
| comment.user?.type === 'User' && | |||
| comment.user?.type !== 'Bot' && | |||
There was a problem hiding this comment.
Are there supposed to be two equal signs, or just 1?
There was a problem hiding this comment.
with typescript i thought it was best to use the triple comparison to avoid any implicit equality comparison
dist/index.js
Outdated
There was a problem hiding this comment.
I'm not sure what this change is. Could it be explained a little better?
There was a problem hiding this comment.
this was the change i got from running the npm run build from the contributing guide
|
Hello @jayudey-wf, Thank you for submitting this PR! We will review it and we will get back to you once we have some feedback on this :) |
Description:
I was noticing that several of the places where I had instrumented the stale action it seemed like some of the pr's were having the label's appropriately applied but the action was never coming back around and closing them after the determined stale period.
I ran a small version of this as part of a small script and saw that the output indicated that the github actions comment was a 'Bot' type.
Related issue:
Add link to the related issue.
Check list: