Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server bind accepts types impling regular service traits #403

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Oct 23, 2021

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

As title. This should help with fallible services.

@robjtede robjtede marked this pull request as ready for review October 28, 2021 20:04
@robjtede robjtede requested a review from fakeshadow October 28, 2021 20:24
Copy link
Member

@aliemjay aliemjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to ditch ServiceFactoryFactory!

actix-server/src/builder.rs Show resolved Hide resolved
actix-service/src/and_then.rs Outdated Show resolved Hide resolved
actix-service/src/and_then.rs Outdated Show resolved Hide resolved
actix-server/src/builder.rs Show resolved Hide resolved
@robjtede robjtede marked this pull request as draft November 1, 2021 22:53
@robjtede
Copy link
Member Author

robjtede commented Nov 1, 2021

Trying to integrate this with Actix Web is proving to be the blocker. De-prioritizing this until next major version of -server to speed up actix-web v4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants