refactor(geo): Geometry visualization update #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Turns this from a typedef over an array to a struct with constructors from ints, doubles and hex strings. color renaming continued fixes after fstream removal refactor: Move visualization logic into Surface, Volume, Polyhedron refactor: Update `ColorRGB` to `Color`
paulgessinger
force-pushed
the
feat/obj-objects
branch
from
6f1768d to
007a854
Compare
paulgessinger
commented
Oct 2, 2024
paulgessinger
commented
Oct 3, 2024
benjaminhuth
reviewed
Oct 3, 2024
|
Can you approve @benjaminhuth? |
benjaminhuth
approved these changes
Oct 7, 2024
|
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
Related to #3502
The most significant changes include adding visualization methods to
TrackingGeometryandTrackingVolume, updating theSurfaceclass, and enhancing theIVisualization3Dinterface. Additionally, theObjVisualization3Dclass has been refactored, and new default view configurations have been defined.Visualization Enhancements:
TrackingGeometry.hpp: Added avisualizemethod to enable visualization of tracking geometry, including substructures. ([Core/include/Acts/Geometry/TrackingGeometry.hppR148-R158](https://github.com/acts-project/acts/pull/3681/files#diff-cc497a4ee5032615db90ef065e9466279a0fde38fbd201840a32d783d3d6ec4aR148-R158))TrackingVolume.hpp: Added methods to visualize tracking volumes and manage surfaces, includingvisualize,surfaces, andaddSurface. ([[1]](https://github.com/acts-project/acts/pull/3681/files#diff-835fb549fb77cdaa632a4e2131c8dc17ad4973ab3f1600a4608582b706a3f68eR326-R344),[[2]](https://github.com/acts-project/acts/pull/3681/files#diff-835fb549fb77cdaa632a4e2131c8dc17ad4973ab3f1600a4608582b706a3f68eR477-R487),[[3]](https://github.com/acts-project/acts/pull/3681/files#diff-835fb549fb77cdaa632a4e2131c8dc17ad4973ab3f1600a4608582b706a3f68eR550))Interface Updates:
IVisualization3D.hpp: Introduced a destructor and a newobjectmethod to start a new object context. ([Core/include/Acts/Visualization/IVisualization3D.hppR75-R80](https://github.com/acts-project/acts/pull/3681/files#diff-c56ccee98d351daf6ac595cd265d30716a594ceb74030138411595aca66fdc39R75-R80))ObjVisualization3D.hpp: Refactored to usedoubleas the value type and added support for object contexts. ([[1]](https://github.com/acts-project/acts/pull/3681/files#diff-fab69ace861a3e5d8fc173e8627732777a5fdd52703e9e162a14db563ea56a2aL29-R32),[[2]](https://github.com/acts-project/acts/pull/3681/files#diff-fab69ace861a3e5d8fc173e8627732777a5fdd52703e9e162a14db563ea56a2aR76-R102))Configuration and Defaults:
ViewConfig.hpp: Defined new default view configurations for surfaces, portals, volumes, and other elements. ([[1]](https://github.com/acts-project/acts/pull/3681/files#diff-e403e98244e75d6b7d32864417c37619de6becee73f53415b733073f655f0929R114-R117),[[2]](https://github.com/acts-project/acts/pull/3681/files#diff-e403e98244e75d6b7d32864417c37619de6becee73f53415b733073f655f0929R139-R146))Codebase Cleanup:
ObjVisualization3D.ipp. ([Core/include/Acts/Visualization/detail/ObjVisualization3D.ippL1-L179](https://github.com/acts-project/acts/pull/3681/files#diff-29bbb6e8cfcb388c51d1e88237dd0c7d582762d7e05a0ec12278bdc336b0aaa1L1-L179))