Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fatras): remove nuclear interaction #3935

Merged
merged 10 commits into from
Dec 16, 2024
Merged

refactor(fatras): remove nuclear interaction #3935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb1af4b
rn
AJPfleger Dec 2, 2024
0e29ac6
Merge branch 'main' into fatras
asalzburger Dec 4, 2024
f5f467a
Merge branch 'main' into fatras
kodiakhq[bot] Dec 4, 2024
9fa02d3
start resolve conflicts
AJPfleger Dec 5, 2024
ed7d134
Merge branch 'main' into fatras
AJPfleger Dec 5, 2024
89f916a
finish resolve conflicts
AJPfleger Dec 5, 2024
27e46a8
Merge branch 'main' into fatras
AJPfleger Dec 5, 2024
2872d74
Merge branch 'main' into fatras
asalzburger Dec 16, 2024
18f8846
Merge branch 'main' into fatras
kodiakhq[bot] Dec 16, 2024
f993d59
Merge branch 'main' into fatras
kodiakhq[bot] Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Examples/Algorithms/Fatras/include/ActsExamples/Fatras/FatrasSimulation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "ActsExamples/Framework/ProcessCode.hpp"
#include "ActsExamples/Framework/RandomNumbers.hpp"
#include "ActsExamples/MagneticField/MagneticField.hpp"
#include "ActsFatras/Physics/NuclearInteraction/NuclearInteraction.hpp"

#include <cstddef>
#include <memory>
Expand Down Expand Up @@ -48,8 +47,6 @@ class FatrasSimulation final : public IAlgorithm {
/// The simulated hits output collection.
std::string outputSimHits;
/// Parametrisation of nuclear interaction
std::string imputParametrisationNuclearInteraction =
"nuclearInteractionParameters";
/// Random number service.
std::shared_ptr<const RandomNumbers> randomNumbers;
/// The tracking geometry that should be used.
Expand Down
9 changes: 4 additions & 5 deletions Examples/Python/src/ExampleAlgorithms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ void addExampleAlgorithms(Context& ctx) {

ACTS_PYTHON_DECLARE_ALGORITHM(
ActsExamples::FatrasSimulation, mex, "FatrasSimulation", inputParticles,
outputParticles, outputSimHits, imputParametrisationNuclearInteraction,
randomNumbers, trackingGeometry, magneticField, pMin, emScattering,
emEnergyLossIonisation, emEnergyLossRadiation, emPhotonConversion,
generateHitsOnSensitive, generateHitsOnMaterial, generateHitsOnPassive,
averageHitsPerParticle);
outputParticles, outputSimHits, randomNumbers, trackingGeometry,
magneticField, pMin, emScattering, emEnergyLossIonisation,
emEnergyLossRadiation, emPhotonConversion, generateHitsOnSensitive,
generateHitsOnMaterial, generateHitsOnPassive, averageHitsPerParticle);

ACTS_PYTHON_DECLARE_ALGORITHM(ActsExamples::ParticlesPrinter, mex,
"ParticlesPrinter", inputParticles);
Expand Down
1 change: 0 additions & 1 deletion Fatras/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ add_library(
src/EventData/ProcessType.cpp
src/Kernel/SimulationError.cpp
src/Physics/BetheHeitler.cpp
src/Physics/NuclearInteraction/NuclearInteraction.cpp
src/Physics/PhotonConversion.cpp
src/Physics/StandardInteractions.cpp
src/Utilities/LandauDistribution.cpp
Expand Down
Loading
Loading