Change default UI port for QLever UI to 8176 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port 7000 is used by default on Mac for AirPlay
hannahbast
changed the title
hannahbast
changed the title
# Conflicts: # src/qlever/qleverfile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for the QLever UI was 7000, but this port is not available on macOS (which is used by a lot of our users). We now take port 8176, which happens to be the concatenated ASCII codes of the first two letters of QLever and is not listed on https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers as a widely used port (neither officially nor unofficially). Fixes #49