-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeatherS2 board from Unexpected Maker #105
base: main
Are you sure you want to change the base?
Add FeatherS2 board from Unexpected Maker #105
Conversation
Copied definition.json from feather-esp32s2
add boot-drive.png
@MakeItYourself85 Feel free to ping me (@brentru) when you're ready for a review! |
@brentru Ready for review |
@MakeItYourself85 Have you started step 2 (building WipperSnapper) and step 3 (modifying wippersnapper) for this board as described here: https://learn.adafruit.com/how-to-add-a-new-board-to-wippersnapper/build-wippersnapper-with-platformio? |
@brentru I was able to successfully build one of the existing projects (featheresp32s2) with platformio. However, the Unexpected Maker FeatherS2 board was not yet supported so I tried updating the platformio.ini file as follows: |
Thanks for the detailed log! Could you copy and paste the |
; Unexpected Maker FeatherS2 @brentru : Sorry, I forgot to mention you on this message when I posted it last week |
@MakeItYourself85 With two minor changes, I was able to build (untested as I don't have hardware for this:)
Here are the two changes I made which differed from your build: Within
In
Please try applying these two changes and compiling them. It should be OK! |
Seems like something broke when I was updating the naming conventions per https://learn.adafruit.com/how-to-add-a-new-board-to-wippersnapper/modifying-firmware. I'll keep working on it before I'm ready for another review. |
@MakeItYourself85 it looks like your giving it another push, good work! You'll need a matching branch in the Wippersnapper Arduino firmware repo too, mainly the boards file needs updating to have your entry too. Can't really test this until Wednesday when Brent returns, but I'll chat with Loren about how we can support in-development boards better on Tuesday. It's good timing as we plan to add some new in-development boards soon too! |
Created with Digital and Analog IO definitions
Included board image and boot-drive image
Still missing: