Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feeds: review code #443

Merged
merged 5 commits into from
Nov 20, 2023
Merged

feeds: review code #443

merged 5 commits into from
Nov 20, 2023

Conversation

adbar
Copy link
Owner

@adbar adbar commented Nov 9, 2023

No description provided.

@adbar adbar marked this pull request as draft November 9, 2023 12:18
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (abfe094) 96.84% compared to head (ab9faf7) 96.88%.

❗ Current head ab9faf7 differs from pull request most recent head efd4228. Consider uploading reports for the commit efd4228 to get more accurate results

Files Patch % Lines
trafilatura/feeds.py 93.93% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   96.84%   96.88%   +0.04%     
==========================================
  Files          22       22              
  Lines        3361     3344      -17     
==========================================
- Hits         3255     3240      -15     
+ Misses        106      104       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar marked this pull request as ready for review November 20, 2023 16:43
@adbar adbar merged commit 71c1661 into master Nov 20, 2023
10 of 12 checks passed
@adbar adbar deleted the feeds_code branch November 20, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant