Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preserve_space option to keep original format in code blocks #772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unsleepy22
Copy link
Contributor

Currently preserve_space is forced False in sanitize method when converting xml to text, while for code blocks esp. python code we wish to preserve spaces to keep the original format since space matters in python.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (91c567c) to head (eed8c0b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          21       21           
  Lines        3587     3588    +1     
=======================================
+ Hits         3561     3562    +1     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar linked an issue Dec 24, 2024 that may be closed by this pull request
@adbar
Copy link
Owner

adbar commented Dec 24, 2024

Hi @unsleepy22, a few comments on the PR:

Last, if you have several PRs in store about unrelated parts of the code it would be best to send them all at once, I don't plan to maintain the software on a day-to-day basis, we could both save time by grouping requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve horizontal space in code blocks
2 participants