Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint config: disable 'relay/graphql-naming' rule #1459

Merged
merged 3 commits into from
Dec 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/eslint-config-adeira/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- Disabled rule `relay/graphql-naming` which is no longer accurate. We might enable it later again once this issue gets resolved: https://github.com/relayjs/eslint-plugin-relay/issues/107

# 4.1.0

- Enable [`node/process-exit-as-throw`](https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/process-exit-as-throw.md) rule. This is potentially breaking, however, the impact should be minimal and the migration simple. Let us know in case it caused troubles, please.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ Object {
"react/void-dom-elements-no-children": 2,
"relay/compat-uses-vars": 0,
"relay/generated-flow-types": 2,
"relay/graphql-naming": 2,
"relay/graphql-naming": 0,
"relay/graphql-syntax": 2,
"relay/hook-required-argument": 2,
"relay/must-colocate-fragment-spreads": 2,
Expand Down
2 changes: 1 addition & 1 deletion src/eslint-config-adeira/ourRules.js
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ module.exports = ({
// Relay (https://github.com/relayjs/eslint-plugin-relay)
'relay/compat-uses-vars': OFF, // we do not use Relay Compat
'relay/generated-flow-types': ERROR,
'relay/graphql-naming': ERROR,
'relay/graphql-naming': OFF, // no longer needed, see: https://github.com/facebook/relay/commit/ff1c10bc6595f3715f29660b46f779e000be9c70
'relay/graphql-syntax': ERROR,
'relay/hook-required-argument': ERROR,
'relay/must-colocate-fragment-spreads': ERROR,
Expand Down
1 change: 0 additions & 1 deletion src/ya-comiste-react-native/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ module.exports = {
rules: {
// TODO: use @adeira/relay
'no-restricted-imports': OFF,
'relay/graphql-naming': OFF,
},
};