Universe: use Relay 13 and the new Rust Compiler #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
efa7cbd to
1ad374d
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
1ad374d to
9067987
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
9067987 to
4dc7202
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
4dc7202 to
62bab7a
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
62bab7a to
1d0da05
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
1d0da05 to
082f2e8
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
082f2e8 to
0fe26fd
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
mrtnzlml
commented
Sep 3, 2021
src/abacus-backoffice/src/products/__generated__/ProductsCardsInCategoryQuery.graphql.js
Show resolved
Hide resolved
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
0fe26fd to
5e61f60
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
5e61f60 to
ebca323
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
changed the title
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
9cfdd12 to
e4fec04
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
e4fec04 to
461031b
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
commented
Jan 6, 2022
| "relay-runtime": "^12.0.0" | ||
| "react-relay": "^13.0.0", | ||
| "relay-compiler": "^13.0.0", | ||
| "relay-config": "0.0.0-main-d92b9e55", |
There was a problem hiding this comment.
I will remove Relay Config together with the fetch-schema.js bin removal. This config dependency is useless in Relay 13+
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
461031b to
4a805c6
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
This was referenced Jan 7, 2022
This commit upgrades Relay to version 13 and switches from the old Relay Compiler to the new Rust one (since both things go together). Basically, the main change is that now we have only one Relay config for the whole monorepo and the compiler is being executed for the whole monorepo as well (while being much faster). Additionally, Relay support is directly integrated into Flow so in many cases I simply removed previous Flow types (see `useLazyLoadQuery` and `useFragment`). There is still ongoing effort to improve the Flow types in Relay so not everything is finalized. For this reason I decided to use "Compat" types mode. Similarly, some hooks (`useMutation` and `usePreloadedQuery` for example) still require explicit types information so I didn't change these yet. Regardless of that, we are pretty close to use "Final" types. We just need to wait for the Relay team to finish everything. Many issues were already resolved but there are still some that need to be fixed (not blocking this PR): - facebook/relay#3700 - relayjs/eslint-plugin-relay#131 - prettier/prettier#6102 Important links with additional information: - https://relay.dev/blog/2021/12/08/introducing-the-new-relay-compiler/ - https://github.com/facebook/relay/releases/tag/v13.0.0 - https://github.com/facebook/relay/releases/tag/v13.0.0-rc.0 - https://github.com/facebook/relay/releases/tag/v13.0.0-rc.1 - https://github.com/facebook/relay/releases/tag/v13.0.0-rc.2
mrtnzlml
force-pushed
the
universe_new_relay_compiler
branch
from
4a805c6 to
dc0ca9e
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
tbergquist-godaddy
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades Relay to version 13 and switches from the old
Relay Compiler to the new Rust one (since both things go together).
Basically, the main change is that now we have only one Relay config
for the whole monorepo and the compiler is being executed for the whole
monorepo as well (while being much faster). Additionally, Relay support
is directly integrated into Flow so in many cases I simply removed
previous Flow types (see
useLazyLoadQueryanduseFragment).There is still ongoing effort to improve the Flow types in Relay so not
everything is finalized. For this reason I decided to use "Compat" types
mode. Similarly, some hooks (
useMutationandusePreloadedQueryforexample) still require explicit types information so I didn't change
these yet. Regardless of that, we are pretty close to use "Final" types.
We just need to wait for the Relay team to finish everything.
Many issues were already resolved but there are still some that need to
be fixed (not blocking this PR):
Important links with additional information: