Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPA-173] Add info label - Improve component #5

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

robergro
Copy link
Contributor

  • Remove unnecessary dependencies.
  • Rename description to helper and add deprecated init and properties.
  • Add info label on UIKit.
  • Remove UIControl inheritance on UIKit and properties (isEnabled, isHighlighted, isSelected).
  • Update snapshots.

Copy link

@LouisBorleeAdevinta LouisBorleeAdevinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the labels (helper and info) should be made public so we wouldn't have to handle things in initializers

Also now that I think about it, helper and info are kind of synonyms, maybe we could find another wording like "supplementaryHelper" or I don't know

Sources/Core/View/SwiftUI/FormFieldView.swift Outdated Show resolved Hide resolved
Sources/Core/ViewModel/FormFieldViewModel.swift Outdated Show resolved Hide resolved
@robergro
Copy link
Contributor Author

/buildDemo component/formfield

Copy link

SparkDemo.app is available.

Process:

  1. Download the app with the link above.
  2. Download if needed the Sparkans mac os app.
  3. Launch Sparkans, on the Simulators entry on the sidebar, select the simulator you want and add the SparkDemo.app file.
  4. Envoy ;)

@robergro
Copy link
Contributor Author

/buildDemo component/formfield

Copy link

SparkDemo.app is available.

Process:

  1. Download the app with the link above.
  2. Download if needed the Sparkans mac os app.
  3. Launch Sparkans, on the Simulators entry on the sidebar, select the simulator you want and add the SparkDemo.app file.
  4. Envoy ;)

@robergro robergro merged commit 63f4caa into main Oct 24, 2024
3 checks passed
@robergro robergro deleted the feature/improve branch October 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants