merge #4
Merged
merge #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: enable bound store props in runes mode components * add some JSDoc, since it could be a headscratcher for future us * make it clear that this is specifically about bindings * skip intermediate value * tweak other names too --------- Co-authored-by: Rich Harris <[email protected]>
* chore: setup `pkg.pr.new` * chore: let's try with this
…node removal (#13884) * set onfinish to null to fix a rare bug * replace null by noop
Adds a changeset for #13884
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* typo: HTMLDiveElement * regenerate types * add changeset --------- Co-authored-by: Conduitry <[email protected]>
* clarify why we need to use the derived rune * put clarification as note
* fix: ensure SVG element attributes have case preserved * fix: ensure SVG element attributes have case preserved * fix: ensure SVG element attributes have case preserved
Besides being private API that shouldn't be exposed, they caused our AST explorer on the Svelte site to traverse endlessly fixes sveltejs/svelte.dev#480
* chore: highlight swallowed errors from await blocks in DEV * chore: highlight swallowed errors from await blocks in DEV * chore: highlight swallowed errors from await blocks in DEV * lint * feedback * feedback * add test * Update packages/svelte/tests/runtime-runes/samples/await-no-catch-error/main.svelte --------- Co-authored-by: Simon H <[email protected]>
…13924) * fix: ensure value is correctly set to zero on the progress element * fix: ensure value is correctly set to zero on the progress element * fix: ensure value is correctly set to zero on the progress element
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…13942) * fix: add empty stack to `CompileDiagnostic` to show error on build * chore: generate types * chore: make stack optional to make TS happy * chore: generate types -.-" * chore: add comment
Co-authored-by: Oscar Dominguez <[email protected]>
* fix: more exhaustive check during `SvelteMap.set` in deriveds * chore: use set for version reactions * chore: cleanup
A full stop or colon, we myst choose
* Update 03-lifecycle-hooks.md * Update documentation/docs/06-runtime/03-lifecycle-hooks.md Co-authored-by: Paolo Ricciuti <[email protected]> --------- Co-authored-by: Paolo Ricciuti <[email protected]>
Update (some) of the links pointing to the old preview site as mentioned in #13982. This updates all the links in documentation/ and packages/svelte/messages, but doesn't touch others present in packages/svelte/ or fix the original link in that issue.
* feat: each without as WIP closes #8348 * properly * docs * changeset * real world demo * simplify * typo --------- Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
a instead of an before failed
playgrounds/sandbox/run.js doesn't work for components containing bigints, because they can't be serialized to JSON. There isn't really a great fix for this issue but this at least allows the sandbox to run
* feat: allow snippets to be exported from module scripts * tweak type * fix issue + add test * refactor * refactor * fix exports error * fix lint * fix lint * error on undefined export * hoisted snippets belong in transform state, not analysis * put the code where it's used * drop the local_. just binding. it's cleaner * simplify * simplify * simplify * simplify * tidy up * oops * update message, add some details * lint * Apply suggestions from code review * add some docs * Update packages/svelte/src/compiler/phases/3-transform/utils.js * Update .changeset/famous-parents-turn.md --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Simon H <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Also fix adjacent code examples closes #14187
* chore: add test for binding event reactive context * revised
…rovided (#14507) * fix: leave update expressions untransformed unless a transformer is provided * fix more cases
…e warning (#14192) * turn `reactive_declaration_non_reactive_property` into a runtime warning * ignore warning * Update packages/svelte/src/internal/client/reactivity/effects.js Co-authored-by: Simon H <[email protected]> * Update packages/svelte/src/internal/client/runtime.js Co-authored-by: Simon H <[email protected]> * fix * test * changeset * Update .changeset/witty-turtles-bake.md Co-authored-by: Simon H <[email protected]> * add some details * check * regenerate --------- Co-authored-by: Simon H <[email protected]>
Co-authored-by: Oscar Dominguez <[email protected]>
…14525) * fix: ensure SvelteDate cached methods have no reactive context * fix: ensure SvelteDate cached methods have no reactive context * fix * lint * use active reaction at time of instance creation * tweak changeset * Update packages/svelte/src/internal/client/dom/elements/bindings/shared.js Co-authored-by: Paolo Ricciuti <[email protected]> --------- Co-authored-by: Dominic Gannaway <[email protected]> Co-authored-by: Paolo Ricciuti <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: capture infinite_loop_guard in error boundary * fix
* fix: don't try to add owners to non-`$state` class fields `$state.raw` and `$derived(.by)` will not have a state symbol on them, potentially causing a disastrous amount of traversal to potentially not find any state symbol. So it's better to not traverse them. Potentially someone could create a `$state` while creating `$state.raw` or inside a `$derived.by`, but that feels so much of an edge case that it doesn't warrant a perf hit for the common case. Fixes #14491 * for bind:, too
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge