fix(proxy scheduler): exit filter step early when scheduling gates are found #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwanad
changed the title
marwanad
force-pushed
the
count-scheduling-gates
branch
from
f740767 to
de86215
Compare
marwanad
force-pushed
the
count-scheduling-gates
branch
2 times, most recently
from
02e24c9 to
bdd0022
Compare
marwanad
force-pushed
the
count-scheduling-gates
branch
from
bdd0022 to
b63c3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We use admiralty alongside Kueue for scheduling plain pod workloads on the target clusters. For plain pod management, Kueue utilizes scheduling gates to block the scheduling cycle from running. The scheduling gate remains on the pod until Kueue admits the pod when quota is available. Pods that are scheduling gated don't have the
PodReasonUnschedulableas the condition reason and therefore, may cause unnecessary delays in the filter step since it polls for the entirety of the 30 seconds waiting forPodReasonUnschedulable.This fixes this logic to consider pods with scheduling gates as unschedulable.