Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ufoLib to v3.0.0 #645

Closed
wants to merge 1 commit into from
Closed

Update ufoLib to v3.0.0 #645

wants to merge 1 commit into from

Conversation

miguelsousa
Copy link
Member

No description provided.

@anthrotype
Copy link
Member

🤞

@anthrotype
Copy link
Member

anthrotype commented Oct 11, 2018

ok that failure is a known one, but believe me it's a feature ;)
https://travis-ci.org/adobe-type-tools/afdko/jobs/440211784#L2126

basically makeinstancesufo or mutatorMath (not sure) is attempting to write a UFO to a path whose parent directory doesn't exist. Previously ufoLib would silently create all the directory tree (as in mkdir -p), now it fails with an error ("Cannot write to ...; the directory does not exist"), which is the right thing to do.

See unified-font-object/ufoLib#60

@anthrotype
Copy link
Member

this other failure is because checkoutlinesufo.py is modifying the UFOWriter.layerContents dictionary using a bytes string as the key (line 139, the global variable PROCD_GLYPHS_LAYER_NAME).
It should use unicode string instead, because the pyfilesystem2 API only accepts unicode strings for path names.

https://travis-ci.org/adobe-type-tools/afdko/jobs/440211784#L1518

@miguelsousa
Copy link
Member Author

Thanks for the insights Cosimo.

@miguelsousa
Copy link
Member Author

I was going to submit a patch to mutatorMath for the directory tree creation problem, but I think a better move for afdko is to resume the work on #402.

@anthrotype
Copy link
Member

that sounds like a better plan. but ufoProcessor will have the same problem

@miguelsousa
Copy link
Member Author

miguelsousa commented Oct 11, 2018

but ufoProcessor will have the same problem

Right.

Anyways, it's clearer now what work lies ahead for afdko and in which order it should be done. We'll probably go straight to fontTools.ufoLib when we're ready, rather than ufoLib==3.0.0.

@miguelsousa miguelsousa deleted the update-ufolib branch October 11, 2018 22:22
@miguelsousa miguelsousa mentioned this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants