Skip to content

stellar-strkey vulnerable to panic in SignedPayload::from_payload

Moderate severity GitHub Reviewed Published Oct 24, 2023 in stellar/rs-stellar-strkey • Updated Nov 9, 2023

Package

cargo stellar-strkey (Rust)

Affected versions

< 0.0.8

Patched versions

0.0.8

Description

Impact

Panic vulnerability when a specially crafted payload is used.
This is because of the following calculation:

inner_payload_len + (4 - inner_payload_len % 4) % 4

If inner_payload_len is 0xffffffff, (4 - inner_payload_len % 4) % 4 = 1 so

inner_payload_len + (4 - inner_payload_len % 4) % 4 = u32::MAX + 1

which overflow.

Patches

Check that inner_payload_len is not above 64 which should never be the case.
Patched in version 0.0.8

Workarounds

Sanitize input payload before it is passed to the vulnerable function so that bytes in payload[32..32+4] and parsed as a u32 is not above 64.

References

GitHub issue #58

References

@C0x41lch0x41 C0x41lch0x41 published to stellar/rs-stellar-strkey Oct 24, 2023
Published to the GitHub Advisory Database Oct 25, 2023
Reviewed Oct 25, 2023
Published by the National Vulnerability Database Oct 25, 2023
Last updated Nov 9, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
Low

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

EPSS score

0.078%
(36th percentile)

Weaknesses

CVE ID

CVE-2023-46135

GHSA ID

GHSA-5873-6fwq-463f

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.