Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up cloudrun deploy #8

Merged
merged 18 commits into from
Oct 1, 2024
Merged

Wire up cloudrun deploy #8

merged 18 commits into from
Oct 1, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Sep 27, 2024 •
edited
Loading

I believe that this will get us to the point of being able to run the backup job in production.

@stdavis stdavis requested a review from steveoh September 27, 2024 22:00
@stdavis stdavis requested a review from jacobdadams September 27, 2024 22:00
steveoh
steveoh approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I manually linked the secrets when testing the function. That will need to be wired up with firebase configuration code.

functions/main.py Outdated Show resolved Hide resolved
@stdavis stdavis merged commit 848a405 into main Oct 1, 2024
7 checks passed
@stdavis stdavis deleted the dev branch October 1, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveoh steveoh steveoh approved these changes

@jacobdadams jacobdadams Awaiting requested review from jacobdadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdavis @steveoh