PR: focus-group support toolbar
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Mar 23, 2024
focus-group.js
Outdated
|
|
||
| function getToolbarItems(group) { | ||
| let items = [...group.querySelectorAll('*')] | ||
| return items.filter((item)=> { |
There was a problem hiding this comment.
Previously I used only Editor Config for the project should I install Prettier auto formatter ?
There was a problem hiding this comment.
Editor Config is for general settings (indent, new line format, etc).
Prettier is about formatting the code, where to add spaces, etc.
I recommend installing it since it is an industry standard nowadays.
But you can keep code formatting manually if you don’t want to install it.
There was a problem hiding this comment.
formatted
There was a problem hiding this comment.
Prettier is awesome I just clarified the info
ai
reviewed
Mar 23, 2024
|
Ping me when PR will be ready for review |
ai
reviewed
Mar 26, 2024
| @@ -1,4 +1,6 @@ | |||
| const ROLES = { | |||
ai
reviewed
Mar 26, 2024
| </div> | ||
| </div> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Let’ add a text that button must have type=button.
|
Thanks. Released in 0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work for the #17