Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds focusgroup attribute basic support #46

Merged
merged 3 commits into from
Oct 29, 2024
Merged

adds focusgroup attribute basic support #46

merged 3 commits into from
Oct 29, 2024

Conversation

mezhnin
Copy link
Contributor

@mezhnin mezhnin commented Oct 29, 2024

Notice: I had to slightly increase size-limit value in package.json to pass the tests.

focus-group.js Outdated Show resolved Hide resolved
@ai
Copy link
Owner

ai commented Oct 29, 2024

We also need:

  1. To add to test/demo
  2. Add section to README.md » Focus Group. You can just add an example, I will write more text.

@ai ai merged commit fc209be into ai:main Oct 29, 2024
4 checks passed
@mezhnin
Copy link
Contributor Author

mezhnin commented Oct 30, 2024

We also need:

  1. To add to test/demo
  2. Add section to README.md » Focus Group. You can just add an example, I will write more text.

There are 3 demo blocks with focusgroup attribute in test/demo (inline, block and no value). I don't know what else to add.
I will update Readme in a next PR.
Thanks for the merge.

@mezhnin
Copy link
Contributor Author

mezhnin commented Oct 30, 2024

We also need:

  1. To add to test/demo
  2. Add section to README.md » Focus Group. You can just add an example, I will write more text.

#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants