Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphysics tuning PR #177

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
7b39eb3
Change saturation
nbren12 Mar 5, 2021
52118a1
Another suggestion of Linjiongs
nbren12 Mar 5, 2021
7a2b2b4
Decrease even further
nbren12 Mar 5, 2021
1015da4
Revert "Decrease even further"
nbren12 Mar 5, 2021
e40c856
Revert "Another suggestion of Linjiongs"
nbren12 Mar 5, 2021
3a38a38
Revert "Change saturation"
nbren12 Mar 5, 2021
2b5aab2
Reduce rh dependent factor
nbren12 Mar 5, 2021
f038d35
Change auto-conversion temperature threshold
nbren12 Mar 9, 2021
36a1782
nix: build fv3 with nix
nbren12 Mar 17, 2021
b5f1bf4
Repair bug in CI
nbren12 Mar 17, 2021
7367c7a
Use cachix in circle build
nbren12 Mar 17, 2021
5fd19bc
Push to specified cache
nbren12 Mar 17, 2021
9efbbe1
Run tests in nix CircleCI builds
nbren12 Mar 17, 2021
c33d481
Fix nix-build calls
nbren12 Mar 17, 2021
21e6049
Make rudimentary test
nbren12 Mar 17, 2021
5905866
Attempt repair of nix-mac
nbren12 Mar 17, 2021
f12f6d7
Fix again
nbren12 Mar 17, 2021
af37ac0
Delete install script
nbren12 Mar 17, 2021
ed62097
Revert dockerfile and test cahnge
nbren12 Mar 17, 2021
9425de0
Remove unused file
nbren12 Mar 17, 2021
fd1fbce
Cleanup unused code
nbren12 Mar 17, 2021
a15d2b8
Use vulcanclimatemodeling cachix
nbren12 Mar 17, 2021
49d7378
Google auth for mac builds
nbren12 Mar 17, 2021
c5222a5
Delete unused file
nbren12 Mar 17, 2021
1b12883
Document the nix workflow
nbren12 Mar 17, 2021
df00733
More doc
nbren12 Mar 17, 2021
be810c4
Make it clear that cachix is optional
nbren12 Mar 17, 2021
c709d7f
Better docs
nbren12 Mar 17, 2021
f4a6a9d
Comment on tox test
nbren12 Mar 17, 2021
61a260e
Revert change to configure.fv3
nbren12 Mar 17, 2021
7518318
Revert "Change auto-conversion temperature threshold"
Mar 18, 2021
8d097ee
Revise the cloud ice deposition and sublimation process.
linjiongzhou Mar 18, 2021
7e613f2
fv_cmp.f90: workaround reference to qi_gen
Mar 18, 2021
d8a36b3
microphysics: enhance effect of qi_lim
Mar 18, 2021
9abeb39
nix: big sur mac builds
nbren12 Mar 19, 2021
c626c0b
Update README.md
nbren12 Mar 19, 2021
420a84a
Merge branch 'feature/nix-rebased' into mp-changes-1
nbren12 Mar 19, 2021
7093a56
microphysics: reduce cloud ice sublimation
nbren12 Mar 19, 2021
50eaf72
cloud-ice: new tuning parameter
nbren12 Mar 19, 2021
7560e45
Merge branch 'master' into mp-changes-1
nbren12 Mar 30, 2021
297922e
Revert "Revise the cloud ice deposition and sublimation process."
nbren12 Mar 30, 2021
4dc5a74
microphysics: simplify ice-->vapor transition rate
nbren12 Mar 30, 2021
cd7dddd
microphysics: parameterize water-vapor transition
nbren12 Mar 30, 2021
9ec1005
microphysics: remove limits on h_var magnitude
nbren12 Mar 30, 2021
f1a238d
microphysics: delete another limiter
nbren12 Mar 30, 2021
09ef08d
Revert "microphysics: delete another limiter"
nbren12 Mar 30, 2021
3fcf3c1
Revert "microphysics: remove limits on h_var magnitude"
nbren12 Mar 30, 2021
691cffe
Remove the changes in fv_cmp.F90.
linjiongzhou Mar 31, 2021
9816047
Add the RH factor to the rain evaporation.
linjiongzhou Mar 31, 2021
396a274
microphysics: parameterize sublimation processes
nbren12 Apr 5, 2021
dcee278
add graupel deposition parameter
nbren12 Apr 12, 2021
73f87fc
Parameterize convective trigger thresholds
nbren12 Apr 22, 2021
8eae741
revert rain evaporation factor change
nbren12 May 4, 2021
87fe79a
Revert "revert rain evaporation factor change"
nbren12 May 12, 2021
674dd11
deep conv: parameterize cinarcmn
nbren12 May 28, 2021
2caa879
deep conv: add timescale_grid_factor parameter
nbren12 May 28, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion FV3/atmos_cubed_sphere/model/fv_cmp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ module fv_cmp_mod
use constants_mod, only: rvgas, rdgas, grav, hlv, hlf, cp_air
use fv_mp_mod, only: is_master
use fv_arrays_mod, only: r_grid
use gfdl_cloud_microphys_mod, only: ql_gen, qi_gen, qi0_max, ql_mlt, ql0_max, qi_lim, qs_mlt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbren12 This change should be removed.

use gfdl_cloud_microphys_mod, only: ql_gen, qi0_max, ql_mlt, ql0_max, qi_lim, qs_mlt
use gfdl_cloud_microphys_mod, only: icloud_f, sat_adj0, t_sub, cld_min
use gfdl_cloud_microphys_mod, only: tau_r2g, tau_smlt, tau_i2s, tau_v2l, tau_l2v, tau_imlt, tau_l2r
use gfdl_cloud_microphys_mod, only: rad_rain, rad_snow, rad_graupel, dw_ocean, dw_land, tintqs
Expand Down Expand Up @@ -109,6 +109,7 @@ module fv_cmp_mod

real :: d0_vap !< the same as dc_vap, except that cp_vap can be cp_vap or cv_vap
real :: lv00 !< the same as lv0, except that cp_vap can be cp_vap or cv_vap
real :: qi_gen ! TODO this is no longer provided in Linjiongs fork.

real, allocatable :: table (:), table2 (:), tablew (:), des2 (:), desw (:)

Expand Down
13 changes: 9 additions & 4 deletions FV3/gfsphysics/physics/gfdl_cloud_microphys.F90
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ module gfdl_cloud_microphys_mod
real :: resmin = 150.0, resmax = 10000.0
real :: regmin = 300.0, regmax = 10000.0

! Linjiong-Noah custom tunining parameters
! TODO give these better names
real :: rs_factor = 0.2
real :: rh_factor = 10.0

! -----------------------------------------------------------------------
! namelist
! -----------------------------------------------------------------------
Expand All @@ -320,7 +325,7 @@ module gfdl_cloud_microphys_mod
rad_snow, rad_graupel, rad_rain, cld_min, use_ppm, mono_prof, &
do_sedi_heat, sedi_transport, do_sedi_w, de_ice, icloud_f, irain_f, &
mp_print, reiflag, rewmin, rewmax, reimin, reimax, rermin, rermax, &
resmin, resmax, regmin, regmax, tintqs
resmin, resmax, regmin, regmax, tintqs, rs_factor, rh_factor

public &
mp_time, t_min, t_sub, tau_r2g, tau_smlt, tau_g2r, dw_land, dw_ocean, &
Expand All @@ -334,7 +339,7 @@ module gfdl_cloud_microphys_mod
rad_snow, rad_graupel, rad_rain, cld_min, use_ppm, mono_prof, &
do_sedi_heat, sedi_transport, do_sedi_w, de_ice, icloud_f, irain_f, &
mp_print, reiflag, rewmin, rewmax, reimin, reimax, rermin, rermax, &
resmin, resmax, regmin, regmax, tintqs
resmin, resmax, regmin, regmax, tintqs, rs_factor, rh_factor

contains

Expand Down Expand Up @@ -2083,7 +2088,7 @@ subroutine subgrid_z_proc (ktop, kbot, p1, den, denfac, dts, rh_adj, tz, qv, &
! factor = min (1., fac_l2v * sqrt (max (0., ql (k)) / 1.e-5) * 10. * dq0 / qsw)
! factor = fac_l2v
! factor = 1
factor = min (1., fac_l2v * (10. * dq0 / qsw)) ! the rh dependent factor = 1 at 90%
factor = min (1., fac_l2v * (rh_factor * dq0 / qsw)) ! the rh dependent factor = 1 at 90%
evap = min (ql (k), factor * dq0 / (1. + tcp3 (k) * dwsdt))
else ! condensate all excess vapor into cloud water
! -----------------------------------------------------------------------
Expand Down Expand Up @@ -2181,7 +2186,7 @@ subroutine subgrid_z_proc (ktop, kbot, p1, den, denfac, dts, rh_adj, tz, qv, &
qi_crt = qi_gen * min (qi_lim, 0.1 * tmp) / den (k)
sink = min (sink, max (qi_crt - qi (k), pidep), tmp / tcpk (k))
else ! ice -- > vapor
pidep = pidep * min (1., dim (tz (k), t_sub) * 0.2)
pidep = pidep * min (1., dim (tz (k), t_sub) * rs_factor)
sink = max (pidep, sink, - qi (k))
endif
qv (k) = qv (k) - sink
Expand Down